Opened on 08/30/2017 at 09:40:49 AM
Closed on 09/19/2017 at 06:56:14 AM
#5595 closed defect (fixed)
Add missing app icons to project & clean up file names.
| Reported by: | CraftyDeano | Assignee: | dzhang |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | app icon, iOS |
| Cc: | mario, ashephard, dzhang, tiago, martin | Blocked By: | |
| Blocking: | Platform: | iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by ashephard)
Environment
The current version of Xcode is giving warnings for missing icon files and rename existing files.
For ABP: "A 83.5x83.5@2x app icon is required for iPad apps targeting iOS 9.0 and later."
For ABP Action Extension: "A 83.5x83.5@2x app icon is required for iPad apps targeting iOS 9.0 and later."
Also, this will be a good time to standardise the naming convention for app icons to something more explicit.
Example: appicon-40@3x.png instead of appicon-120.png
Full Iconset Sizes Required:
20x20px
29x29px
40x40px
60x60px
87x87px
167x167px
1024x1024px
How to reproduce
- Build project
- Check warnings
Attachments (2)
Change History (8)
comment:1 Changed on 09/01/2017 at 07:24:51 AM by mario
- Cc tiago martin added
comment:2 Changed on 09/12/2017 at 11:30:55 AM by ashephard
There is a codereview linked to this (https://codereview.adblockplus.org/29541880/), which will add a requirement for a 1024x1024px in the app.
Changed on 09/12/2017 at 01:29:48 PM by martin
Here's a an archive with all sizes needed (as per Apple's documentation). Check those out and let me know if something needs fixing.
Changed on 09/12/2017 at 01:51:13 PM by martin
Updated ticket with archive containing icons for ABP
comment:4 Changed on 09/12/2017 at 09:14:56 PM by dzhang
- Owner set to dzhang
comment:5 Changed on 09/13/2017 at 03:18:15 PM by ashephard
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/19/2017 at 06:56:14 AM by dzhang
- Resolution set to fixed
- Status changed from reviewing to closed
@Tiago, Martin, can you provide the missing icons?