Opened on 09/01/2017 at 09:11:15 AM

Closed on 09/12/2017 at 02:51:43 PM

#5607 closed change (fixed)

Namespace content styles in website-defaults

Reported by: ire Assignee: ire
Priority: P2 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette, wspee, ire, saroyanm Blocked By: #5573
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29538612

Description

Background

In 5573 we will add a CSS reset to website-deaults, which will remove many default styles that are applied by browsers to native elements, e.g. padding, margins, font styling.

We want these styles to be applied to content blocks.

What to change

Add default styling to native elements, e.g headings, lists, but namespaced.

Attachments (0)

Change History (7)

comment:1 Changed on 09/01/2017 at 09:11:33 AM by ire

  • Blocked By 5573 added

comment:2 Changed on 09/04/2017 at 10:56:55 AM by juliandoucette

  • Priority changed from P3 to P2

Bumped priority because of blocking.

comment:3 Changed on 09/04/2017 at 10:59:50 AM by juliandoucette

  • Cc ire saroyanm added
  • Keywords goodfirstbug added
  • Ready set

comment:4 Changed on 09/07/2017 at 11:46:05 AM by ire

  • Owner set to ire

comment:5 Changed on 09/07/2017 at 12:08:54 PM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 09/12/2017 at 02:50:05 PM by abpbot

A commit referencing this issue has landed:
​Issue 5607 - Namespace content styles in website-defaults

comment:7 Changed on 09/12/2017 at 02:51:43 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.