Opened on 09/05/2017 at 06:35:31 PM
Closed on 09/07/2017 at 01:06:50 AM
#5623 closed change (fixed)
Change the version format of devbuilds of ABP for Microsoft Edge
| Reported by: | oleksandr | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | kvas, sebastian, kzar, tlucas | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently the manifest.json of a development build of ABP for Microsoft Edge has a version value in a format like 0.9.11.0.1834. That is no longer supported by the Windows Store. Instead a value like 0.9.11.1834 is supported.
What to change
Change the devbuild generation routine to use the version format like 0.9.11.1834.
Attachments (0)
Change History (4)
comment:1 Changed on 09/05/2017 at 06:44:32 PM by sebastian
- Cc tlucas added
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 09/05/2017 at 08:04:06 PM by sebastian
- Component changed from Sitescripts to Platform
comment:3 Changed on 09/07/2017 at 12:58:07 AM by abpbot
A commit referencing this issue has landed:
Issue 5623 - Change the version format of devbuilds of ABP for Microsoft Edge
comment:4 Changed on 09/07/2017 at 01:06:50 AM by oleksandr
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
I cannot find any code in either sitescripts nor buildtools that adds the redundant .0 to the version. It seems it is coming from the metadata.edge file in adblockpluschrome.