Opened on 09/06/2017 at 09:41:23 PM
Closed on 10/11/2017 at 04:08:30 PM
Last modified on 11/13/2017 at 01:59:12 PM
#5634 closed change (fixed)
Change the abp.org header into a navbar
| Reported by: | juliandoucette | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | P2 | Milestone: | adblockplus.org 1.1.0 |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | wspee, ire | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
3 & 4: Remove logo & refactor [width, colors]: https://codereview.adblockplus.org/29551738/ |
||
Description (last modified by juliandoucette)
Background
See adblockplus.org 2.x.
What to change
Change abp.org header into a red navbar as-seen in milestone desktop and mobile designs.
Notes
It makes sense to break this up into a few steps:
- Remove search
- Remove locale flags
- Replace logo
- Refactor width and colors
Also, because we don't have time:
- Avoid adding new accessibility features
- Avoid adding new strings
(I will refactor this later using a website-defaults navbar component after we have implemented websites code sharing.)
Attachments (0)
Change History (25)
comment:1 Changed on 09/06/2017 at 09:46:19 PM by juliandoucette
- Blocked By 5635 added
comment:2 Changed on 09/06/2017 at 10:01:44 PM by juliandoucette
- Blocking 5636 added
comment:3 Changed on 09/18/2017 at 01:19:56 PM by juliandoucette
- Blocked By 5635 removed
comment:4 Changed on 09/18/2017 at 05:05:22 PM by juliandoucette
- Cc wspee ire removed
- Summary changed from Change the adblockplus.org header into a navbar to Change the abp.org header into a navbar
comment:5 Changed on 09/18/2017 at 05:52:48 PM by juliandoucette
- Blocking 5725 added
comment:6 Changed on 09/20/2017 at 02:24:27 PM by juliandoucette
- Priority changed from P3 to P2
comment:7 Changed on 09/20/2017 at 02:50:47 PM by juliandoucette
- Blocking 5725 removed
comment:8 Changed on 09/20/2017 at 02:51:26 PM by juliandoucette
- Milestone changed from adblockplus.org 2.1.0 to adblockplus.org 1.1.0
comment:9 Changed on 09/20/2017 at 04:10:22 PM by juliandoucette
- Owner set to juliandoucette
comment:10 Changed on 09/21/2017 at 02:52:00 PM by juliandoucette
- Owner juliandoucette deleted
comment:11 Changed on 09/21/2017 at 10:41:31 PM by juliandoucette
- Cc wspee ire added
- Description modified (diff)
- Owner set to juliandoucette
comment:12 Changed on 09/21/2017 at 10:43:40 PM by juliandoucette
- Description modified (diff)
comment:13 Changed on 09/21/2017 at 10:45:55 PM by juliandoucette
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:14 Changed on 09/21/2017 at 11:24:55 PM by juliandoucette
- Review URL(s) modified (diff)
comment:15 Changed on 09/21/2017 at 11:26:01 PM by juliandoucette
- Description modified (diff)
comment:16 Changed on 09/22/2017 at 01:22:53 AM by juliandoucette
- Review URL(s) modified (diff)
comment:17 Changed on 09/22/2017 at 01:23:37 AM by juliandoucette
- Review URL(s) modified (diff)
comment:18 Changed on 09/22/2017 at 06:19:19 PM by abpbot
comment:19 Changed on 09/22/2017 at 06:58:10 PM by abpbot
A commit referencing this issue has landed:
Issue 5634 - Backed out changeset 42c83a80689b
comment:20 Changed on 09/25/2017 at 02:41:37 PM by juliandoucette
comment:21 Changed on 09/25/2017 at 02:49:41 PM by juliandoucette
comment:22 Changed on 10/11/2017 at 04:08:30 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
comment:23 Changed on 10/23/2017 at 08:26:11 PM by juliandoucette
- Description modified (diff)
comment:24 Changed on 10/26/2017 at 11:49:09 AM by juliandoucette
- Blocking 5636 removed
comment:25 Changed on 11/13/2017 at 01:59:12 PM by abpbot
Some commits referencing this issue have landed:
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5634 - Removed search from header