Opened on 09/07/2017 at 07:29:41 PM

Closed on 09/11/2017 at 02:54:23 PM

#5641 closed defect (fixed)

Misplaced content on abdlockplus.org/edge

Reported by: sebastian Assignee: ire
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: saroyanm, juliandoucette, wspee, ire Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29541555/

Description

Environment

Reproduced in Chrome 59 and Firefox 53

How to reproduce

Go to https://adblockplus.org/edge with a browser that is not Microsoft Edge.

Observed behaviour

Instead of the "Agree and install" button the text "Adblock Plus for Microsoft Edge requires Windows 10 Anniversary Update" appears, this is to be expected. However, this text is out of place covering other content.

Also the text "By clicking the Agree and Install button below, you agree to our Terms of Use." is shown even though the button is hidden.

Expected behaviour

The content should not overlap. If no button is there, the text "By clicking the Agree and Install button below, you agree to our Terms of Use." shouldn't be shown either.

Attachments (1)

abp_org_edge.png (17.3 KB) - added by sebastian on 09/07/2017 at 07:29:53 PM.

Download all attachments as: .zip

Change History (8)

Changed on 09/07/2017 at 07:29:53 PM by sebastian

comment:1 Changed on 09/08/2017 at 08:02:12 AM by wspee

  • Cc ire added
  • Ready set

comment:2 Changed on 09/08/2017 at 08:13:17 AM by wspee

  • Priority changed from Unknown to P2

comment:3 Changed on 09/08/2017 at 08:14:21 AM by wspee

comment:4 Changed on 09/11/2017 at 07:58:51 AM by ire

  • Owner set to ire

comment:5 Changed on 09/11/2017 at 08:12:14 AM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 09/11/2017 at 02:53:56 PM by abpbot

A commit referencing this issue has landed:
Issue 5641 - Misplaced content on abdlockplus.org/edge

comment:7 Changed on 09/11/2017 at 02:54:23 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.