Opened on 09/08/2017 at 09:23:54 AM
Closed on 09/28/2017 at 12:44:07 PM
#5643 closed change (fixed)
Make v8::Isolate injectable into JsEngine
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | fhd, asmirnov | Blocked By: | #5556, #5570 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
According to the description of #5570 we should delegate creation of v8::Isolate to third-party developers, but in libadblockplus-android there should be a way to inject that v8::Isolate.
What to do
Ask third-parties how libadblockplus-android is used and make corresponding changes.
Attachments (0)
Change History (5)
comment:1 Changed on 09/08/2017 at 09:27:51 AM by asmirnov
Last edited on 09/08/2017 at 09:29:10 AM
by asmirnov
comment:2 Changed on 09/08/2017 at 09:35:46 AM by sergz
I would like to merely precise it, I think, it should be added to the Builder and used when JsEngine is being configured, similar to appInfo. And right, there should be a trivial C++ implementation of AdblockPlus::IV8IsolateProvider in JNI which is created only in JniSetUpJsEngine.
comment:3 Changed on 09/26/2017 at 08:56:53 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 09/28/2017 at 12:43:11 PM by abpbot
A commit referencing this issue has landed:
Issue 5643 - Make v8::Isolate injectable into JsEngine
comment:5 Changed on 09/28/2017 at 12:44:07 PM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
i'm going to add void useV8Isolate(long ptr) method to AdblockHelper in order to pass ptr to v8::Isolate.
Actually i already did it but for some older revision of libadblockplus and i was going to merge the changes back to libadblockplus-android. This will require to create c++ IV8Provider structure inheritor in JNI glue layer to keep reference because of latest changes in libadblockplus (not done yet)