Opened on 09/11/2017 at 11:28:23 AM

Closed on 10/26/2017 at 02:59:53 PM

#5651 closed change (fixed)

Set relative values for strong and small elements in website-defaults

Reported by: ire Assignee: juliandoucette
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29588979

Description

Background

Currently in website-defaults, the weight of strong and size of small elements are set using absolute pixel values. This does not allow for properly styled nested elements.

What to change

Change the value of font-weight on strong,b to bolder (supported since CSS Level 1)

Change the value of font-size on small to a relative value (e.g. 80%)

Attachments (0)

Change History (5)

comment:1 Changed on 09/13/2017 at 01:32:59 PM by juliandoucette

  • Priority changed from Unknown to P3

comment:2 Changed on 10/25/2017 at 08:24:41 PM by juliandoucette

  • Owner set to juliandoucette

comment:3 Changed on 10/25/2017 at 08:24:50 PM by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/26/2017 at 02:59:24 PM by abpbot

A commit referencing this issue has landed:
Issue 5651 - Set relative values for strong and small

comment:5 Changed on 10/26/2017 at 02:59:53 PM by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from juliandoucette.
 
Note: See TracTickets for help on using tickets.