Opened on 09/13/2017 at 12:52:52 PM
Last modified on 09/13/2017 at 07:57:18 PM
#5669 new defect
ABP for Safari on macOS blocks its own settings page with *adblock* filter
Reported by: | petruc | Assignee: | |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Unknown | Keywords: | |
Cc: | sebastian, kzar, mapx | Blocked By: | |
Blocking: | Platform: | Safari | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
macOS 10.12.5
Safari 10.1.1 (12603.2.4)
ABP Safari 1.12.4
Native Safari content blocking disabled.
Filters:
EasyPrivacy+EasyList
Adblock Warning Removal List
Fanboy's Annoyance List
Malware Domains
Spam404
I don't care about cookies
Prebake - Filter Obtrusive Cookie Notices
How to reproduce
- Add
*adblock*
as a custom filter.
- Close and reopen ABP Settings page.
...
Observed behaviour
- Most of the options in the ABP Settings page vanish. The remaining elements are non-functional.
- The Settings page is unusable to the point of having to reinstall ABP Safari extension.
Expected behaviour
The ABP Settings page should be exempted from being filtered by ABP itself, and always kept functional.
Other comments
I came across this by naively adding
*adblock*
as custom filter, to remove a "disable your adblocker to see our site" curtain. Many of the DIV elements had that string in ID or NAME. Of course it was a noob move, I should've used proper syntax for the filter. But I was soooo angry at that specific site...
Adding the following custom exception filters:
@@|safari-extension://*^$document @@||org.adblockplus.adblockplussafari-*
protected the Settings page perfectly, and could even be added as hidden filters in ABD for Safari, but maybe the developers have a better solution for that.
Anyways, thank you for your hard work and wish you all the best!
Attachments (0)
Change History (4)
comment:1 Changed on 09/13/2017 at 04:31:20 PM by mapx
- Cc sebastian kzar mapx added
comment:2 Changed on 09/13/2017 at 04:39:38 PM by sebastian
- Priority changed from Unknown to P4
- Ready set
comment:3 Changed on 09/13/2017 at 07:49:25 PM by hfiguiere
comment:4 Changed on 09/13/2017 at 07:57:18 PM by sebastian
I agree, that this is a problem. But this issue existed ever since, and the Safari extension is a low priority for us at the moment. However, if somebody submits a patch, I'm happy to include it in the next release, which we might have soon.
Also I couldn't find a way to reset this short of removing the extension and reinstalling it.