Opened on 09/13/2017 at 06:35:29 PM

Closed on 09/18/2017 at 11:53:00 AM

#5672 closed defect (fixed)

Misplaced content on adblockplus.org/maxthon

Reported by: sebastian Assignee: ire
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: wspee, ire, juliandoucette, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29544557/

Description (last modified by greiner)

Environment

Chrome 61 / Firefox 53

How to reproduce

Go to https://adblockplus.org/en/maxthon

Observed behaviour

As seen in the attached screenshot:

  • There is an empty space on the left, where previously the YouTube video was.
  • The text "By clicking the Agree and Install button below, you agree to our Terms of Use." appears even though there is no install button for Maxthon (as it is a build-in feature of their browser).

Expected behaviour

  • The YouTube video should appear.
  • The terms of use disclaimer should not appear.

Attachments (1)

maxthon.png (52.7 KB) - added by sebastian on 09/13/2017 at 06:35:45 PM.

Download all attachments as: .zip

Change History (6)

Changed on 09/13/2017 at 06:35:45 PM by sebastian

comment:1 Changed on 09/14/2017 at 07:41:42 AM by ire

  • Owner set to ire
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 09/14/2017 at 08:12:25 AM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/15/2017 at 01:26:38 PM by greiner

  • Cc greiner added
  • Description modified (diff)

I noticed that this issue only occurs for certain languages so I updated the link in the ticket description to make sure that it can be reliably reproduced.

comment:4 Changed on 09/18/2017 at 11:50:58 AM by abpbot

A commit referencing this issue has landed:
Issue 5672 - Misplaced content on adblockplus.org/maxthon

comment:5 Changed on 09/18/2017 at 11:53:00 AM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.