Opened on 09/14/2017 at 09:52:58 AM

Closed on 09/26/2017 at 12:12:37 PM

Last modified on 10/23/2017 at 03:00:32 PM

#5675 closed defect (fixed)

Firefox icon used for media playback notifications

Reported by: jwangenheim Assignee: jwangenheim
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29545555/

Description (last modified by jwangenheim)

Description

With FENNEC 53 a notification is shown when a website plays a video or audio. Currently the notification uses the Firefox instead of the ABB icon.
The icon also should be renamed from ic_status_logo to abb_ic_status_logo, so we make it less susceptible to have our logo replaced by Firefox in future merges.

Environment

First build of ABB 53.0.2 merge
Nexus 5X
Android 8
Galaxy S5
Android 6.0.1

How to reproduce

  1. Go to youtube.com
  2. Click on a video
  3. The notification is shown

Observed behaviour

The Firefox icon pops up in the system bar.

Expected behaviour

The ABB icon pops up in the system bar.

Attachments (3)

Screenshot_20170914-112819.png​ (165.4 KB) - added by jwangenheim on 09/14/2017 at 09:53:47 AM.
Screenshot_20170914-112837.png​ (139.2 KB) - added by jwangenheim on 09/14/2017 at 09:53:57 AM.
abb_ic_status_logo.zip​ (7.2 KB) - added by martin on 09/14/2017 at 01:55:31 PM.
Updated ticket with the missing xxhdpi asset.

Download all attachments as: .zip

Change History (11)

Changed on 09/14/2017 at 09:53:47 AM by jwangenheim

Changed on 09/14/2017 at 09:53:57 AM by jwangenheim

comment:1 Changed on 09/14/2017 at 01:43:46 PM by jwangenheim

  • Component changed from Unknown to Adblock-Browser-for-Android
  • Platform changed from Unknown / Cross platform to Adblock Browser for Android

Changed on 09/14/2017 at 01:55:31 PM by martin

Updated ticket with the missing xxhdpi asset.

comment:2 Changed on 09/15/2017 at 07:33:18 AM by jwangenheim

  • Description modified (diff)

comment:3 Changed on 09/19/2017 at 12:06:09 PM by jwangenheim

  • Status changed from new to reviewing

comment:4 Changed on 09/20/2017 at 02:29:05 PM by abpbot

A commit referencing this issue has landed:
​Issue 5675 - Firefox icon used for media playback notifications

comment:5 Changed on 09/26/2017 at 12:12:37 PM by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 09/26/2017 at 02:45:51 PM by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next

comment:7 Changed on 10/05/2017 at 12:26:24 AM by traynard

  • Verified working set

comment:8 Changed on 10/23/2017 at 03:00:32 PM by diegocarloslima

  • Review URL(s) modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.