Opened on 09/14/2017 at 04:26:00 PM
Closed on 10/26/2017 at 03:04:58 PM
#5683 closed defect (fixed)
Make og:url(s) locale specific
| Reported by: | juliandoucette | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | saroyanm, greiner, kvas, jsonesen, wspee, ire, paco, ferris | Blocked By: | |
| Blocking: | #1274 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29588973, |
||
Description (last modified by juliandoucette)
Environment
All websites shares on Facebook.
How to reproduce
Share a non-English page URL on Facebook. Repeat the same test after changing your browser, system, and Facebook locale appropriately.
Observed behavior
- The Facebook website preview is always in English (See Facebook bug)
- The Facebook website share is English most of the time
Expected behavior
Facebook should scrape each og:locale:alternate and show each locale appropriately (according to your Facebook locale).
Suggested fix
Add locale to og:url(s).
I think this contradicts ogp.me's definition of og:url as a "canonical" link. But I see no alternative at this point. We need a reliable way to share non-English website pages on Facebook to resolve #1274. The implications of this fix are {1: Shares for individual pages may be counted separately per locale, 2: Shares will not be translated on Facebook according to the user's Facebook locale (instead, they will appear in the locale specified in the shared URL e.g. /en/page, /de/page)}
Attachments (0)
Change History (13)
comment:2 Changed on 09/14/2017 at 04:43:54 PM by juliandoucette
comment:3 Changed on 09/14/2017 at 04:52:00 PM by juliandoucette
I created this website based on this sourcecode to test this issue. The website contains the following pages:
In English and German:
- http://julian.eyeofiles.com/en/
- http://julian.eyeofiles.com/en/top
- http://julian.eyeofiles.com/en/sub/
- http://julian.eyeofiles.com/de/
- http://julian.eyeofiles.com/de/top
- http://julian.eyeofiles.com/de/sub/
With nginx (serving/redirecting according to Accept-Language header and fb_locale) og:url, og:locale, and og:locale:alternate(s) configured appropriately. e.g.
comment:4 Changed on 09/14/2017 at 05:12:35 PM by juliandoucette
- Blocking 1274 added
comment:6 Changed on 09/14/2017 at 05:26:03 PM by juliandoucette
- Cc paco ferris added
comment:7 Changed on 09/28/2017 at 11:21:26 PM by rraceanu
Issue still occurs, verified multiple OS's / browsers.
comment:8 Changed on 10/25/2017 at 07:50:41 PM by juliandoucette
- Ready set
comment:9 Changed on 10/25/2017 at 07:50:49 PM by juliandoucette
- Owner set to juliandoucette
comment:10 Changed on 10/25/2017 at 08:03:37 PM by juliandoucette
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:11 Changed on 10/26/2017 at 03:01:52 PM by abpbot
A commit referencing this issue has landed:
Issue 5683 - Made og:url locale specific
comment:12 Changed on 10/26/2017 at 03:03:45 PM by abpbot
A commit referencing this issue has landed:
Issue 5683 - Made og:url locale specific
comment:13 Changed on 10/26/2017 at 03:04:58 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
@wspee I believe that we have implemented og:url, og:locale, og:locale:alternate, and fb_locale correctly according to all available documentation. But it wouldn't hurt to have QA test this issue before I give up and UN-canonicalize our og:url(s). Can you organize this?