Opened on 09/14/2017 at 09:11:17 PM

Last modified on 09/18/2017 at 05:06:08 PM

#5685 reviewing change

Pass ESLint

Reported by: hfiguiere Assignee: hfiguiere
Priority: P5 Milestone:
Module: Libadblockplus Keywords:
Cc: sergz Blocked By: #5509
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29545700/

Description (last modified by hfiguiere)

Background

Issue #5509 will add ESLint to the build. Running it will error. We need to fix that.

What to change

Make the .js files pass ESLint.

Attachments (0)

Change History (5)

comment:1 Changed on 09/14/2017 at 09:11:45 PM by hfiguiere

  • Description modified (diff)

comment:2 Changed on 09/14/2017 at 09:12:02 PM by hfiguiere

  • Owner set to hfiguiere

comment:3 Changed on 09/15/2017 at 04:38:40 PM by sergz

  • Cc sergz added
  • Priority changed from Unknown to P5

comment:4 Changed on 09/15/2017 at 07:47:01 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 09/18/2017 at 05:06:08 PM by abpbot

A commit referencing this issue has landed:
​Issue 5685 - Pass ESLint

Add Comment

Modify Ticket

Change Properties
Action
as reviewing .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.