Opened on 09/18/2017 at 09:59:50 AM
Closed on 09/20/2017 at 02:53:07 PM
#5703 closed change (fixed)
Add CSS fallback for hidden attribute to website-defaults
| Reported by: | ire | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | juliandoucette, wspee | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We may want to use the hidden attribute to hide elements on the page.
Most current browsers automatically add display: none; to elements with this attribute, but some browsers we support do not. See http://caniuse.com/#feat=hidden
What to change
Add the following CSS to website-defaults _reset.scss
[hidden]
{
display: none;
}
Attachments (0)
Change History (7)
comment:2 in reply to: ↑ 1 Changed on 09/18/2017 at 01:22:34 PM by juliandoucette
- Ready set
Replying to ire:
Priority P2 because I am planning on using this attribute in https://issues.adblockplus.org/ticket/4925
Ack.
comment:3 Changed on 09/18/2017 at 04:15:06 PM by juliandoucette
- Priority changed from P2 to P3
Reducing priority because this is not blocking something of higher priority.
comment:4 Changed on 09/20/2017 at 10:16:48 AM by ire
- Owner set to ire
comment:5 Changed on 09/20/2017 at 10:17:30 AM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/20/2017 at 02:52:19 PM by abpbot
A commit referencing this issue has landed:
Issue 5703 - Add CSS fallback for hidden attribute to website-defaults
comment:7 Changed on 09/20/2017 at 02:53:07 PM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Priority P2 because I am planning on using this attribute in https://issues.adblockplus.org/ticket/4925