Opened on 09/18/2017 at 12:25:32 PM

Closed on 09/22/2017 at 09:51:30 AM

#5706 closed change (fixed)

Add custom filter list dialog is incomplete

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29549891/

Description

Background

After several design iterations we finally have a final version of the new options page (See #5158).

What to change

Add a new field for filter list title and implement error handling as specified ​here.

Attachments (0)

Change History (5)

comment:1 Changed on 09/18/2017 at 12:25:45 PM by saroyanm

  • Blocking 5158 added

comment:2 Changed on 09/18/2017 at 01:07:20 PM by saroyanm

  • Owner set to saroyanm

comment:3 Changed on 09/20/2017 at 11:10:42 AM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 09/22/2017 at 09:50:53 AM by abpbot

A commit referencing this issue has landed:
​Issue 5706 - Finish custom subscription dialog implementation

comment:5 Changed on 09/22/2017 at 09:51:30 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.