remove_redundant_translations fails due to the presence of system file

[diegocarloslima]

How to reproduce

1. On a mac, access through Finder adblockbrowser/mobile/android/base/locales/adblockbrowser/. It will produce a .DS_Store file on that folder.
2. Run python translations.py get API_KEY

Observed behaviour

The script fails with the following error:

Traceback (most recent call last):
  File "translations.py", line 98, in <module>
    remove_redundant_translations()
  File "translations.py", line 84, in remove_redundant_translations
    if not filecmp.dircmp(locale_path, default_locale_path).diff_files:
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 238, in __getattr__
    self.methodmap[attr](self)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 174, in phase3
    xx = cmpfiles(self.left, self.right, self.common_files)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 238, in __getattr__
    self.methodmap[attr](self)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 143, in phase2
    for x in self.common:
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 238, in __getattr__
    self.methodmap[attr](self)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 132, in phase1
    a = dict(izip(imap(os.path.normcase, self.left_list), self.left_list))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 238, in __getattr__
    self.methodmap[attr](self)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/filecmp.py", line 124, in phase0
    self.left_list = _filter(os.listdir(self.left),
OSError: [Errno 20] Not a directory: '/Users/dlima/Workspace/adblockbrowser/mobile/android/base/locales/adblockbrowser/.DS_Store'

Expected behaviour

The script should complete successfully. Files (and ideally hidden directories) should be ignored in remove_redundant_translationsfunction

[abpbot]

A commit referencing this issue has landed:
​Issue 5729 - remove_redundant_translations fails due to the presence of system file

[traynard]

Confirmed with Diego that this is a build issue

[sunnyydv12]

spam