Opened on 05/28/2014 at 10:07:45 AM
Closed on 05/28/2014 at 10:48:38 AM
Last modified on 05/30/2014 at 11:37:16 AM
#573 closed defect (fixed)
Relative URLs aren't blocked in Safari
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8.3-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Safari 7
How to reproduce
Go to a website that uses relative URLs for resources that are supposed to be blocked.
For example: http://tvtotal.prosieben.de/tvtotal/videos/player/index.html?contentId=153848
Where following script is blocked by EasyList Germany: /tvtotal/includes/js/avt.js
Observed behaviour
Despite the filter ||prosieben.de^*/avt.js in Easy List Germany the scripts still loads and shows a preroll ad. That is because the code in the beforeload event handler assumes that the URL is always absolute, and ignores URLs that don't start with "http(s):".
Expected behaviour
Resources using relative URLs must also be blocked. Therefore the relative URL must be joined with the document's URL, to generate an absolute URL used for filter matching.
Attachments (0)
Change History (4)
comment:1 Changed on 05/28/2014 at 10:09:51 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/28/2014 at 10:12:03 AM by mapx
- Cc smultron45@gmail.com added
comment:3 Changed on 05/28/2014 at 10:48:38 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/30/2014 at 11:37:16 AM by sebastian
- Ready set
https://hg.adblockplus.org/adblockpluschrome/rev/2d85c7056347