Opened on 09/20/2017 at 01:23:27 AM

Closed on 09/23/2017 at 01:02:58 AM

#5738 closed defect (fixed)

Fix running of tests on ABP Swift

Reported by: dzhang Assignee: dzhang
Priority: P3 Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: mario, tiago, ashephard, CraftyDeano Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29550808/

Description

Environment

Xcode 9 with ABP, swift branch

How to reproduce

Attempt to run tests.

Observed behaviour

Tests do not run due to build, linking, and provisioning errors.

Expected behaviour

Tests run successfully, locally and under CI.

Attachments (0)

Change History (3)

comment:1 Changed on 09/20/2017 at 05:41:06 PM by dzhang

  • Owner changed from CraftyDeano to dzhang

comment:2 Changed on 09/21/2017 at 02:37:13 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/23/2017 at 01:02:58 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.