Opened on 09/22/2017 at 03:24:59 PM
Closed on 10/27/2017 at 08:48:45 AM
#5754 closed change (fixed)
Update promo image on adblockbrowser.org
| Reported by: | wspee | Assignee: | ire |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug, content |
| Cc: | ire, juliandoucette, wspee, p.pastourmatzis, tpregueiro | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by wspee)
Background
With the release of ABB iOS 2.0 and the upcoming cross promotion we want to update adblockbrowser.org.
What to change
Replace the promo image on the right side of adblockbrowser.org with the new promo image:
Attachments (4)
Change History (23)
Changed on 09/22/2017 at 03:25:15 PM by wspee
comment:1 Changed on 09/22/2017 at 03:26:52 PM by wspee
- Cc ire juliandoucette added
- Component changed from Unknown to Websites
- Milestone set to adblockplus.org 1.1.0
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 09/22/2017 at 03:39:43 PM by wspee
- Ready unset
Changed on 10/09/2017 at 08:35:54 AM by wspee
Changed on 10/09/2017 at 10:11:36 AM by wspee
comment:5 Changed on 10/10/2017 at 11:06:24 AM by juliandoucette
- Cc wspee added
@wpsee can you confirm that this image is final? (I'm not sure that it's an improvement :/)
Changed on 10/10/2017 at 02:25:34 PM by wspee
comment:7 Changed on 10/10/2017 at 02:36:01 PM by wspee
- Cc t.pregueiro@adblockplus.org p.pastourmatzis@eyeo.com added
@Tiago,Paul This is how abb.org will look like after the change. After the back and forth can you please confirm that this is the right image?
comment:8 Changed on 10/13/2017 at 09:29:40 AM by ire
- Owner set to ire
comment:9 Changed on 10/13/2017 at 09:33:18 AM by ire
@wspee: This was marked as ready, but looking at the comments it doesn't seem like this is confirmed. Is this ready to implement?
FTR I agree with Julian. I'm not sure this is an improvement, the image doesn't convey to me that it's a browser that blocks ads
comment:10 Changed on 10/18/2017 at 08:23:31 AM by ire
- Owner ire deleted
comment:11 Changed on 10/23/2017 at 07:58:44 PM by juliandoucette
- Milestone adblockplus.org 1.1.0 deleted
comment:12 Changed on 10/25/2017 at 08:05:49 PM by juliandoucette
- Cc p.pastourmatzis tpregueiro added; t.pregueiro@adblockplus.org p.pastourmatzis@eyeo.com removed
comment:13 Changed on 10/25/2017 at 08:06:32 PM by juliandoucette
- Keywords goodfirstbug content added
- Ready unset
comment:14 Changed on 10/26/2017 at 08:49:38 AM by tpregueiro
@wspee LGTM
comment:16 Changed on 10/26/2017 at 10:47:18 AM by ire
- Owner set to ire
comment:17 Changed on 10/26/2017 at 10:54:08 AM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:18 Changed on 10/27/2017 at 08:47:46 AM by abpbot
A commit referencing this issue has landed:
Issue 5754 - Update promo image on adblockbrowser.org
comment:19 Changed on 10/27/2017 at 08:48:45 AM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
On hold for now, we might want to update the image again.