Opened on 09/25/2017 at 10:14:19 AM
Closed on 09/25/2017 at 11:13:17 AM
Last modified on 10/08/2019 at 05:58:14 PM
#5769 closed defect (fixed)
Bad performance on Firefox, ad counter causes frequent storage updates
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Firefox 55, Adblock Plus 2.99.0.1838beta
How to reproduce
- Go to http://bildblog.de/
Observed behaviour
Multiple severe hangs while the page is loading.
Expected behaviour
No hangs.
Background
This is caused by storage.local being very inefficient in Firefox 55 (Firefox 57 is a lot better). We are causing storage to be saved frequently by updating the ads counter, on Firefox the entire file has to be rewritten for that - meaning all of filters as well.
What to change
Make sure that the ads counter is saved at most once per minute on Firefox.
Attachments (0)
Change History (7)
comment:1 Changed on 09/25/2017 at 11:09:59 AM by abpbot
comment:2 Changed on 09/25/2017 at 11:13:17 AM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 09/25/2017 at 01:40:06 PM by mapx
Are you still using storage.local ?
"Kris Maglione
If you want resource efficiency, use IndexedDB. storage.local is not designed for storing huge amounts of data."
comment:4 Changed on 09/25/2017 at 01:40:30 PM by mapx
- Cc mapx added
comment:5 Changed on 09/25/2017 at 01:42:01 PM by trev
If you follow that discussion a bit further, IndexedDB doesn't really solve the issues. Switching to IndexedDB at this point would be a major effort again and absolutely not worth it.
comment:6 Changed on 09/25/2017 at 08:56:04 PM by sebastian
I cannot judge (at the moment) whether migrating to IndexedDB is worth it on Firefox, and we seem to still have larger fires to fight when it comes to Firefox/WebExt support. However, on Microsoft Edge we already use IndexedDB and might have keep doing so for the foreseeable future. So if there are any advantages of using IndexedDB on Firefox, I would love to see Adblock Plus for Microsoft Edge and Firefox sharing the same storage implementation, at some point.
comment:7 Changed on 09/08/2019 at 08:07:02 PM by djape300
spam
A commit referencing this issue has landed:
Issue 5769 - Worked around bad Firefox 55 storage performance