Opened on 09/25/2017 at 01:16:13 PM
Closed on 12/08/2018 at 01:09:59 AM
#5771 closed defect (worksforme)
ABP prevents loading of Edge about:flags page
| Reported by: | Ross | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, oleksandr, geo | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by oleksandr)
Environment
ABP 0.9.11.1849
Edge 40 / Windows 10
How to reproduce
- Navigate to about:flags in Edge.
- Install ABP for Edge.
- Navigate to about:flags again in Edge.
- Select Edge Menu > Extensions > ABP > Switch slider to off.
- Navigate to about:flags in Edge again.
Observed behaviour
with ABP not installed or turned off, the about:flags page loads successfully, with it installed/on, it does not.
Expected behaviour
ABP should not prevent internal browser pages from loading.
Hints for testers
The fix involved changing the subscription mechanism for listening to webRequests on all browsers. Please make sure all the requests types are blockable on all supported browsers.
The bug was also reproducible for other non http/https URLs. Like file:// or viewing PDF inside Edge etc. Please make sure that is fixed as well.
Attachments (0)
Change History (9)
comment:1 Changed on 09/25/2017 at 08:34:11 PM by sebastian
- Cc oleksandr added
- Component changed from Core to Platform
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 10/24/2017 at 07:54:58 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/08/2017 at 12:55:04 PM by abpbot
comment:4 Changed on 11/08/2017 at 12:57:52 PM by oleksandr
- Description modified (diff)
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 11/21/2017 at 04:58:37 PM by abpbot
A commit referencing this issue has landed:
Revert "Issue 5771 - ABP prevents loading of Edge about:flags page"
comment:6 Changed on 11/21/2017 at 05:00:01 PM by kzar
- Resolution fixed deleted
- Status changed from closed to reopened
It looks like that change at least partially broke WebSocket blocking (#6052) so I've reverted it for now.
comment:7 Changed on 12/05/2018 at 11:46:32 PM by sebastian
- Cc geo added
According to Geo, blocking of WebSockets doesn't work on Microsoft Edge regardless of this change. Can you confirm that WebSocket connections cannot be intercepted through the webRequest API in Microsoft Edge, and if so file a Microsoft Edge bug?
comment:8 Changed on 12/06/2018 at 11:15:09 PM by Ross
The about:flags part of this ticket looks to no longer be an issue.
ABP 0.9.11.2206
Edge 42.17134.1.0 / EdgeHTML 17.17134 / Windows 10 (1803)
comment:9 Changed on 12/08/2018 at 01:09:59 AM by sebastian
- Resolution set to worksforme
- Status changed from reopened to closed
A commit referencing this issue has landed:
Issue 5771 - ABP prevents loading of Edge about:flags page