Opened on 09/25/2017 at 06:16:02 PM
Closed on 09/28/2017 at 11:30:15 AM
#5778 closed defect (fixed)
Hide More filters section when there is no filter
Reported by: | saroyanm | Assignee: | saroyanm |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | jeen | Blocked By: | |
Blocking: | #5158 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by saroyanm)
Environment
Any browser
How to reproduce
- Run ./test_server.py from inside the adblockplusui repository.
- Go to http://localhost:5000/new-options.html
- Observe
Observed behaviour
No empty message and section looks useless
Expected behaviour
This section doesn't exist at all when there is no filter in the section
Attachments (0)
Change History (7)
comment:4 Changed on 09/25/2017 at 08:12:28 PM by saroyanm
- Owner set to saroyanm
comment:5 Changed on 09/25/2017 at 08:12:47 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/28/2017 at 11:29:48 AM by saroyanm
comment:7 Changed on 09/28/2017 at 11:30:15 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Change:
https://hg.adblockplus.org/adblockplusui/rev/241dabc66f52