Opened on 09/25/2017 at 10:12:51 PM

Closed on 09/28/2017 at 11:56:39 AM

#5779 closed defect (fixed)

Missing checkbox in language dialog and persistent validation in new options page

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: jeen Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29556681/

Description

How to reproduce

  1. Run ./test_server.py from inside the adblockplusuirepository.
  2. Go to ​http://localhost:5000/new-options.html
  3. Click on "change" next to the German in Languages section.
  4. Observe
  5. Go to ​http://localhost:5000/new-options.html#advanced
  6. Click on "Add a filter list"
  7. Validate input and remove focus
  8. Observe

Observed behaviour

  • Step 4: No checkbox next to the already subscribed "German" list
  • Step 8: Validated icon disappears after changing the focus

Expected behaviour

  • Step 4: Disabled checkbox next to the already subscribed lists same as in Add language dialog
  • Step 8: Validation should persist after removing the focus

Attachments (0)

Change History (4)

comment:1 Changed on 09/25/2017 at 10:13:13 PM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 09/26/2017 at 06:41:17 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/28/2017 at 11:56:14 AM by abpbot

A commit referencing this issue has landed:
​Issue 5779 - Added missing checkbox in language dialog and validation persistent

comment:4 Changed on 09/28/2017 at 11:56:39 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.