Opened on 09/27/2017 at 12:16:57 AM
Closed on 09/27/2017 at 09:08:20 PM
#5797 closed change (fixed)
Remove obsolete arguments from ElemHideEmulation constructor
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Passing the window object to the ElemHideEmulation constructor was only necessary for the legacy Gecko extension, which is deprecated now.
Passing a callback to retrieve the element hiding emulation patterns asynchronously was only necessary so that these can be provided by a separate message, which is no longer the case (see #5781).
What to change
Remove the window and getFiltersFunc arguments from the ElemHideEmulation constructor. Make ElemHideEmulation.apply() take the patterns as an argument instead.
Attachments (0)
Change History (5)
comment:1 Changed on 09/27/2017 at 12:18:19 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/27/2017 at 01:24:15 AM by hfiguiere
- Cc hfiguiere added
comment:4 Changed on 09/27/2017 at 09:07:01 PM by abpbot
comment:5 Changed on 09/27/2017 at 09:08:20 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5797 - Removed obsolete arguments from ElemHideEmulation constructor