Opened on 05/30/2014 at 11:31:03 AM
Closed on 06/17/2014 at 03:43:59 PM
Last modified on 09/03/2014 at 07:55:41 AM
#581 closed defect (fixed)
Element hiding and collapsing doesn't work within inline frames on Chrome
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5666188336037888 |
||
Description (last modified by sebastian)
Environment
Reproduced in Chrome 34 and 30 on Linux and Windows.
How to reproduce
Go to any web page that shows ads in frames that aren't loaded by their src attribute but constructed with JavaScript.
For example: http://www.chip.de/downloads/Adblock-Plus-fuer-Firefox_22437623.html
Observed behaviour
You see placeholders for two ads whose web request has been blocked by Adblock Plus. This is because Chrome doesn't run content scripts for inline frames, hence the element collapsing code doesn't run. Element hiding won't work for the same reason too.
Expected behaviour
Placeholders for blocked elements must be hidden and element hiding must be applied in all frames.
Attachments (0)
Change History (9)
comment:1 Changed on 05/30/2014 at 11:32:12 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/02/2014 at 10:05:01 AM by sebastian
comment:5 Changed on 06/02/2014 at 01:14:10 PM by sebastian
comment:7 Changed on 06/17/2014 at 03:43:59 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Implemented workaround for older Chrome versions.
https://hg.adblockplus.org/adblockpluschrome/rev/191f69afc9d6
comment:8 Changed on 06/17/2014 at 03:45:21 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Fixed for Chrome 37+ with the new match_about_blank option, see https://crbug.com/76429.
https://hg.adblockplus.org/buildtools/rev/861200067592
https://hg.adblockplus.org/adblockpluschrome/rev/07cc59cd49ae