Opened on 10/06/2017 at 09:13:39 PM
Closed on 10/10/2017 at 05:34:43 PM
Last modified on 10/24/2017 at 06:11:04 PM
#5842 closed defect (fixed)
Spanish and Vietnamese filter lists string assignment missing in the options page
| Reported by: | saroyanm | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, sebastian, wspee | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29567856/ |
||
Description (last modified by saroyanm)
Environment
Firefox
How to reproduce
- Apply patch from here to adblockpluschrome repository
- Build project using python build.py -t gecko-webext devenv
- Load extension from about:debugging
- Navigate to the options page
- Click on "Add a language" button
- Observe
Observed behaviour
https://easylist-downloads.adblockplus.org/abpvn+easylist.txt and https://easylist-downloads.adblockplus.org/easylistspanish+easylist.txt are being shown in the dialog
Expected behaviour
Vietnamese and Spanish are shown accordingly.
Note
This is stopgap solution until this issue is resolved and all languages are updated accordingly.
Attachments (0)
Change History (17)
comment:1 Changed on 10/06/2017 at 09:27:48 PM by saroyanm
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 10/06/2017 at 09:38:07 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 10/06/2017 at 09:38:22 PM by saroyanm
- Owner set to saroyanm
comment:4 Changed on 10/09/2017 at 04:54:57 PM by abpbot
comment:5 Changed on 10/09/2017 at 04:56:18 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 follow-up: ↓ 8 Changed on 10/09/2017 at 07:44:08 PM by sebastian
Since translations have already been requested, and we are in string freeze now, can we please revert this change, and land it after we don't need to update the dependency in adblockpluschrome anymore, for the upcoming release?
comment:7 Changed on 10/09/2017 at 07:49:21 PM by sebastian
- Cc sebastian added
comment:8 in reply to: ↑ 6 Changed on 10/09/2017 at 08:04:17 PM by saroyanm
- Cc wspee added
Replying to sebastian:
Since translations have already been requested, and we are in string freeze now, can we please revert this change, and land it after we don't need to update the dependency in adblockpluschrome anymore, for the upcoming release?
You want me to revert this change from the adblockplusui repository completely and do not introduce any string changes in adblockplusui (while in string freeze), or keep updating strings in adblockplusui (if needed), but stop updating dependencies in adblockpluschrome ?
comment:9 follow-up: ↓ 10 Changed on 10/09/2017 at 08:16:16 PM by sebastian
We cannot stop updating the dependency in adblockpluschrome, yet. We at least have to update it one more time, when the translations arrive. But also need to be able to do fixes if necessary to the new options page, if we find any bugs before the release.
So I suggest to revert this change from adblockplusui and don't land any changes that add new strings, until we don't need to update the dependency in adblockpluschrome anymore.
comment:10 in reply to: ↑ 9 Changed on 10/09/2017 at 08:49:34 PM by saroyanm
Replying to sebastian:
We cannot stop updating the dependency in adblockpluschrome, yet. We at least have to update it one more time, when the translations arrive. But also need to be able to do fixes if necessary to the new options page, if we find any bugs before the release.
So I suggest to revert this change from adblockplusui and don't land any changes that add new strings, until we don't need to update the dependency in adblockpluschrome anymore.
Noted, that's unfortunate, I'll revert the strings back tomorrow in case no more arguments against, or if it's not urgently needs to be done until tomorrow.
comment:11 Changed on 10/10/2017 at 01:07:03 PM by saroyanm
- Resolution fixed deleted
- Status changed from closed to reopened
The changes are reverted.
This issue is reopen again, as the strings added here are added after the string freeze.
comment:12 Changed on 10/10/2017 at 01:08:12 PM by saroyanm
- Owner saroyanm deleted
comment:13 follow-up: ↓ 14 Changed on 10/10/2017 at 04:14:42 PM by sebastian
I think you have to revert the changes to subscription.xml as well. Otherwise, the new subscriptions show up in the UI, but there is no string to show at all, right?
comment:14 in reply to: ↑ 13 Changed on 10/10/2017 at 04:24:04 PM by saroyanm
Replying to sebastian:
I think you have to revert the changes to subscription.xml as well. Otherwise, the new subscriptions show up in the UI, but there is no string to show at all, right?
subscription.xml in the UI is just for test. I think it should stay and reflect actual state of the options page.
We are using subscription.xml from adblockpluscore in the production.
comment:15 Changed on 10/10/2017 at 05:34:01 PM by abpbot
A commit referencing this issue has landed:
Issue 5842 - use specialization instead of translating the language
comment:16 Changed on 10/10/2017 at 05:34:43 PM by saroyanm
- Resolution set to fixed
- Status changed from reopened to closed
comment:17 Changed on 10/24/2017 at 06:11:04 PM by saroyanm
- Review URL(s) modified (diff)
A commit referencing this issue has landed:
Issue 5842 - Add Spanish and Vietnamese languages filter list labels