Opened on 10/09/2017 at 07:29:25 PM

Closed on 11/01/2017 at 07:58:01 AM

#5848 closed defect (fixed)

Fix vertical alignment on .heading-icon images in help.eyeo.com

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29588588/

Description

How to reproduce

  1. Clone help.eyeo.com
  2. Go to ​http://localhost:5000/en/adblockplus/ or any article page

...

Observed behaviour

The ABP icons next to the headings are not properly centered vertically

Expected behaviour

Image should be aligned exactly center vertically

Attachments (0)

Change History (5)

comment:1 Changed on 10/24/2017 at 08:25:37 AM by ire

  • Milestone set to help.eyeo.com 1.0.0
  • Priority changed from Unknown to P3

comment:2 Changed on 10/25/2017 at 09:59:16 AM by ire

  • Owner set to ire

comment:3 Changed on 10/25/2017 at 10:23:32 AM by ire

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 11/01/2017 at 07:57:24 AM by abpbot

A commit referencing this issue has landed:
​Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com

comment:5 Changed on 11/01/2017 at 07:58:01 AM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.