Opened on 10/10/2017 at 09:33:44 AM
Closed on 10/11/2017 at 11:19:50 AM
#5850 closed defect (fixed)
Social media profile links don't open on Help tab
| Reported by: | arthur | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | saroyanm, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Nightly 58.0a1 20171009220104
ABP 2.99.0.1877beta
How to reproduce
- Go into the options of ABP
- Click on "Help"
- Click on the Twitter icon
Observed behaviour
Nightly shows a CSP error page.
Expected behaviour
Nightly should open the Twitter profile page of ABP.
Notes
The Facebook and Google Plus pages also don't open for me but there is no error page.
Attachments (0)
Change History (8)
comment:1 Changed on 10/10/2017 at 09:34:23 AM by arthur
- Platform changed from Firefox to Unknown / Cross platform
comment:2 Changed on 10/10/2017 at 10:14:18 AM by arthur
- Cc greiner added
comment:3 Changed on 10/10/2017 at 01:15:11 PM by saroyanm
- Priority changed from Unknown to P2
- Ready set
comment:4 Changed on 10/10/2017 at 08:05:37 PM by saroyanm
comment:5 Changed on 10/10/2017 at 08:12:57 PM by saroyanm
- Owner set to saroyanm
comment:6 Changed on 10/10/2017 at 08:13:34 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 10/11/2017 at 11:18:58 AM by abpbot
A commit referencing this issue has landed:
Issue 5850 - Fixed broken Social media links
comment:8 Changed on 10/11/2017 at 11:19:50 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
We are loading new options page in the Iframe, so we will need to specify target attribute for the links either "_top" or "_blank".