Opened on 10/10/2017 at 12:12:57 PM
Closed on 11/10/2017 at 12:02:07 PM
#5852 closed change (fixed)
Change hover/focus/active colour for accordion menu on help.eyeo.com
| Reported by: | ire | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | help.eyeo.com 1.0.0 |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | juliandoucette, wspee, jeen | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by ire)
Background
For the accordion menu headers, the current non-active background-color is #ECECEC. The current hover/focus/active colour is #AEAEAE. The latter colour is too dark.
What to change
Use #C4C4C4 as the background-color on hover/focus/active colour
Attachments (2)
Change History (11)
Changed on 10/24/2017 at 08:24:01 AM by ire
Changed on 10/24/2017 at 08:24:12 AM by ire
Active/Hover/Focus State
comment:1 Changed on 10/24/2017 at 08:24:32 AM by ire
- Cc jeen added
comment:2 Changed on 10/24/2017 at 08:25:06 AM by ire
@Jeen could you please advise on what colour the hover/active/focus state for the accordion headers should be? I've attached images with what it currently looks like and the hex colours are in the description
comment:3 Changed on 10/24/2017 at 08:25:16 AM by ire
- Milestone set to help.eyeo.com 1.0.0
- Priority changed from Unknown to P3
comment:4 follow-up: ↓ 5 Changed on 11/08/2017 at 10:13:50 AM by jeen
Hi Ire- let's use #C4C4C4 - it has a better contrast but is still distinguishable from the non-active state.
comment:5 in reply to: ↑ 4 Changed on 11/08/2017 at 03:18:11 PM by ire
- Description modified (diff)
Replying to jeen:
Hi Ire- let's use #C4C4C4 - it has a better contrast but is still distinguishable from the non-active state.
Thanks!
comment:6 Changed on 11/09/2017 at 09:33:36 AM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 11/10/2017 at 12:01:38 PM by abpbot
A commit referencing this issue has landed:
Issue 5852 - Change hover/focus/active colour for accordion menu on help.eyeo.com
comment:8 Changed on 11/10/2017 at 12:02:02 PM by ire
- Owner set to ire
comment:9 Changed on 11/10/2017 at 12:02:07 PM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
Inactive State