Opened on 10/18/2017 at 01:03:11 PM

Closed on 11/16/2017 at 10:54:03 AM

Last modified on 12/03/2017 at 02:41:48 PM

#5872 closed change (fixed)

Apply style changes to the new options page

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords: options-page
Cc: jeen, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29601581/

Description

Background

There were couple of complains regarding the font-size and paddings of the new options page and we currently have a ​fix addressing that concerns.

What to change

Implement style changes mentioned ​here

Attachments (0)

Change History (6)

comment:1 Changed on 10/18/2017 at 01:26:45 PM by saroyanm

  • Keywords options-page added; settings-page removed

comment:2 Changed on 11/02/2017 at 10:14:17 AM by saroyanm

  • Owner set to saroyanm

comment:3 Changed on 11/08/2017 at 03:47:14 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 11/16/2017 at 10:51:36 AM by abpbot

A commit referencing this issue has landed:
​Issue 5872 - Apply style changes to the option page

comment:5 Changed on 11/16/2017 at 10:54:03 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 11/29/2017 at 08:35:05 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Looks fine.

ABP 3.0.1.1939
Firefox 51 / 57 / Windows 7
Chrome 52 / 62 / Windows 7
Opera 38 / 49 / Windows 7

Last edited on 12/03/2017 at 02:41:48 PM by Ross

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.