Opened on 10/19/2017 at 10:40:38 AM
Closed on 10/25/2017 at 03:21:54 PM
Last modified on 11/02/2017 at 02:09:22 PM
#5877 closed defect (fixed)
First run page is missing some text
Reported by: | Ross | Assignee: | tlucas |
---|---|---|---|
Priority: | P1 | Milestone: | |
Module: | Automation | Keywords: | |
Cc: | sebastian, saroyanm, greiner, mjethani, kzar, wspee, tlucas | Blocked By: | |
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description (last modified by kzar)
Environment
ABP 2.99.0.1889beta
Firefox 57 / Windows 10
Also
Firefox 57 Android
Also
Firefox 56.0, Debian Buster, Adblock Plus debuild #1895
How to reproduce
- Ensure previous extension data is cleared so first run page appears.
- Install build.
Observed behaviour
The first run page is missing some (but not all) texts. For example the text of the donate button. Specifically these strings are missing:
firstRun_share_headline firstRun_donate firstRun_donate_label firstRun_share firstRun_contributor_credits
Expected behaviour
The first run page to display correctly / not be missing text
Notes
- The locale files seem to have a different content in the development builds which are online, than when they are generated manually. If you first download the development build based on abd390e823bd, then build the extension yourself with ./build.py -t gecko build, extract both xpi files and compare the differences you will notice quite a few.
- This is apparently a regression caused by this commit d4ca9bfb82b5.
Attachments (1)
Change History (19)
Changed on 10/19/2017 at 10:42:13 AM by Ross
comment:1 Changed on 10/19/2017 at 05:22:35 PM by sebastian
- Cc saroyanm greiner mjethani added
comment:2 Changed on 10/19/2017 at 06:34:33 PM by saroyanm
- Priority changed from Unknown to P2
- Ready set
So far I only can say that it was broken in between Version 2.99.0.1879beta and Version 2.99.0.1881beta builds. Trying to find out which exact change caused this..
In between October 10-12
comment:3 follow-up: ↓ 4 Changed on 10/19/2017 at 06:38:45 PM by sebastian
Well, Ross and I can also reproduce it with *.1889 from AMO and the CWS.
comment:4 in reply to: ↑ 3 Changed on 10/19/2017 at 06:46:04 PM by saroyanm
Replying to sebastian:
Well, Ross and I can also reproduce it with *.1889 from AMO and the CWS.
I meant to say that build *.1879 is not broken(FRP strings are there), while *.1880 and next builds look to be broken.
comment:5 Changed on 10/24/2017 at 03:29:29 PM by saroyanm
- Cc kzar wspee tlucas added
- Component changed from User-Interface to Build-and-Release-Tools
- Priority changed from P2 to Unknown
- Ready unset
I think this issue somehow connected with buildtools, I can confirm that the strings that are missing do exist in the adblockplusui firstRun.json dependency version.
Note: Also the project built locally and the one available online are missing different strings (This is very odd to me).
@Buildtool team can you please have a look, because I'm having hard time of finding what exactly cause the issue. Also the issue started to appear after the current change.
I think we should fix this before the release.
comment:6 follow-up: ↓ 7 Changed on 10/24/2017 at 03:32:25 PM by kzar
(Could possibly be related to #5916, but I've not looked into it yet.)
comment:7 in reply to: ↑ 6 ; follow-up: ↓ 8 Changed on 10/24/2017 at 11:12:10 PM by tlucas
I was able to recreate this using the official dev builds, but i could not recreate this using packages generated locally - just like Sebastian.
However, i managed to create a diff between the two packages - There are only additions, only affecting messages.json files, all additions appear to affect stringIDs with the prefix "firstRun", some locales have more additions then others.
(here's a full list, couldn't think of anything better to distribute this: https://codereview.adblockplus.org/29587789/ )
Replying to kzar:
(Could possibly be related to #5916, but I've not looked into it yet.)
This might be true
comment:8 in reply to: ↑ 7 Changed on 10/25/2017 at 09:07:05 AM by saroyanm
Replying to tlucas:
I was able to recreate this using the official dev builds, but i could not recreate this using packages generated locally - just like Sebastian.
As I mentioned above, package generated locally misses different strings. While the packaged that's available online missed for example string from Donation button. The package generated locally has the string for "Donation" button, but misses Adblock Browser promotion strings, like Get Adblock Browser here.
comment:9 Changed on 10/25/2017 at 09:17:28 AM by kzar
- Description modified (diff)
I can also reproduce this, Tristan and I are investigating.
comment:10 Changed on 10/25/2017 at 01:22:41 PM by kzar
- Description modified (diff)
(here's a full list, couldn't think of anything better to distribute this: https://codereview.adblockplus.org/29587789/ )
I also also reproduce those differences, so the question is what caused them.
comment:11 Changed on 10/25/2017 at 02:05:21 PM by kzar
- Description modified (diff)
comment:12 Changed on 10/25/2017 at 02:06:54 PM by kzar
- Description modified (diff)
comment:13 Changed on 10/25/2017 at 02:16:59 PM by tlucas
- Owner set to tlucas
comment:14 Changed on 10/25/2017 at 02:18:51 PM by kzar
- Priority changed from Unknown to P1
- Ready set
comment:15 Changed on 10/25/2017 at 02:20:16 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:16 Changed on 10/25/2017 at 03:21:26 PM by abpbot
A commit referencing this issue has landed:
Issue 5877 - Account for random locale processing order
comment:17 Changed on 10/25/2017 at 03:21:54 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:18 Changed on 11/02/2017 at 02:09:22 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. All strings now appear correctly on the first run page.
ABP 1.13.4.1903
Chrome 49 / 62 / Windows 10
Opera 36 / 48 / Windows 10
ABP 2.99.0.1902beta
Firefox 50 / 57 / Windows 10
I can reproduce this, both on Firefox and Chrome, when installing the development build from AMO or the CWS. However, I cannot reproduce it when building the extension myself, which is weird and makes it difficult to debug.