Opened on 10/19/2017 at 12:14:25 PM
Closed on 10/20/2017 at 08:12:53 AM
Last modified on 11/02/2017 at 02:04:58 PM
#5880 closed change (fixed)
Create a minimal issue reporter
| Reported by: | fhd | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, wspee, nicole | Blocked By: | |
| Blocking: | #5883 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by fhd)
Background
We're about to move ABP for Firefox to the new WebExtensions code base, which means we will lose our old issue reporter, which means filter list authors will not get issue reports anymore. That's bad, so we want to include at least a minimal issue reporter in the initial release.
What to change
Create an issue reporter that sends at least the following fields:
- subscriptions
- type
- comment
- main_url
Anything else is optional.
Design and copy is not specified. It's OK if this is not translated at first.
Attachments (0)
Change History (8)
comment:2 Changed on 10/19/2017 at 12:29:54 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 10/20/2017 at 07:51:26 AM by abpbot
comment:4 Changed on 10/20/2017 at 08:00:38 AM by abpbot
A commit referencing this issue has landed:
Issue 5880 - Added strings used by issue reporter as well
comment:5 Changed on 10/20/2017 at 08:02:53 AM by abpbot
A commit referencing this issue has landed:
Issue 5880 - Updated adblockplusui dependency and integrated issue reporter
comment:6 Changed on 10/20/2017 at 08:12:13 AM by trev
- Blocking 5883 added
comment:7 Changed on 10/20/2017 at 08:12:53 AM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
I'll create follow-up issues and link them to #5883.
comment:8 Changed on 11/02/2017 at 02:04:58 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Appears to work okay in most recent browser versions.
Fails in older browser versions (covered by #5967).
ABP 1.13.4.1903
Chrome 49 / 62 / Windows 10
Opera 36 / 48 / Windows 10
ABP 2.99.0.1902beta
Firefox 50 / 57 / Windows 10
A commit referencing this issue has landed:
Issue 5880 - Basic issue reporter implementation