Opened on 10/20/2017 at 08:34:41 AM

Closed on 10/22/2017 at 09:36:36 AM

#5889 closed change (fixed)

Issue reporter: links displayed on successful submission should open in top frame

Reported by: trev Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: wspee, nicole, kvas Blocked By:
Blocking: #5883 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29584686/

Description (last modified by kvas)

Background

The issue reporter will display the server response inside a frame. The links will currently open inside that frame which creates a suboptimal user experience.

What to change

Add target="_top" to the links, these should replace the issue reporter page.

Note

See the note in #5890 for instructions for observing the current behavior.

Attachments (0)

Change History (5)

comment:1 Changed on 10/20/2017 at 03:12:06 PM by kvas

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 10/20/2017 at 03:32:46 PM by kvas

  • Owner set to kvas

comment:3 Changed on 10/20/2017 at 03:54:26 PM by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/22/2017 at 09:35:25 AM by abpbot

A commit referencing this issue has landed:
​Issue 5889 - Open links from issue reporter success page in top frame

comment:5 Changed on 10/22/2017 at 09:36:36 AM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kvas.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.