Opened on 10/20/2017 at 08:49:12 AM

Closed on 10/24/2017 at 02:11:00 PM

#5893 closed change (fixed)

Add application vendor information to issue reports

Reported by: trev Assignee: trev
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee, nicole Blocked By:
Blocking: #5883 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29587626/

Description (last modified by trev)

Background

Issue reports backend expects a vendor attribute on the <application> tag and will display "unknown" if it doesn't find one. Our current implementation doesn't add this attribute.

What to change

Populate the vendor attribute with window.navigator.vendor. While at it, upper-case application and platform name - the backend will display them as they are, and all lowercase doesn't look nice.

Attachments (0)

Change History (5)

comment:1 Changed on 10/20/2017 at 08:51:05 AM by trev

  • Description modified (diff)

comment:2 Changed on 10/24/2017 at 12:11:21 PM by trev

  • Owner set to trev

comment:3 Changed on 10/24/2017 at 12:11:30 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/24/2017 at 02:07:29 PM by abpbot

A commit referencing this issue has landed:
​Issue 5893 - Issue reports should include browser vendor and capitalize browser/platform name

comment:5 Changed on 10/24/2017 at 02:11:00 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.