Opened on 10/23/2017 at 01:10:29 PM
Closed on 10/24/2017 at 04:23:08 PM
Last modified on 11/02/2017 at 02:07:37 PM
#5904 closed defect (fixed)
The code in include.preload.js is being run twice
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | mjethani, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Chrome 62, Debian Buster, Adblock Plus devbuild built from 129566c42ebc.
How to reproduce
- Add console.log("uh oh"); to the top of adblockpluschrome/include.preload.js
- Rebuilt the extension
- Browse to https://news.ycombinator.com/
Observed behaviour
"uh oh" appears twice in the console per page load.
Expected behaviour
"uh oh" should only appear once per page load.
Notes
This is a regression from #5080 since the postload code requires the include.preload module. We need to either combine all the content script code into one file which runs at preload, or find another way to share code between the preload and postload bundles.
Attachments (0)
Change History (4)
comment:1 Changed on 10/24/2017 at 01:02:37 PM by kzar
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/24/2017 at 04:22:21 PM by abpbot
comment:3 Changed on 10/24/2017 at 04:23:08 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 11/02/2017 at 02:07:37 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Log message only seen once.
adblockpluschrome / 1903:6b5fdb8e8e45
Chrome 62 / Windows 10
Opera 48 / Windows 10
Firefox 57 / Windows 10
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5904 - Avoid include.preload.js running twice