Opened on 10/24/2017 at 09:37:15 AM

Closed on 08/06/2018 at 06:19:52 PM

#5914 closed change (fixed)

Consider taking screenshots of the page in issue reporter

Reported by: trev Assignee: agiammarchi
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee, nicole, agiammarchi Blocked By:
Blocking: #5883 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/8
​https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/21

Description (last modified by greiner)

Background

Our minimal issue reporter won't create screenshots at this point, yet it's important to filter list authors to see what exactly the user saw on that page.

See also ​ui#26.

What to change

Implement ​spec#122 and consider the following notes:

  • Use tabs.captureVisibleTab() to make a screenshot of the page. This shouldn't require any new permissions, but this functionality only works on the active tab. So we have to call that method immediately when "Report issue on this page" is clicked, before the issue reporter is opened. We have to make sure there isn't a race condition if we open a new tab immediately after calling tabs.captureVisibleTab().
  • We should use <canvas> to scale down the screenshot (neither side should exceed 800 pixel) and reduce color depth (2 bits per channel). This is to reduce the amount of data, but also to protect us against copyright infringement claims.
  • Sending the screenshot should be optional but enabled by default. There should be a step after issue type selection where the screenshot is shown to the user, along with a checkbox saying "Attach a page image to the report."
  • Ideally, the user should also be able to remove some areas of the screenshot and mark others.

Attachments (0)

Change History (5)

comment:1 Changed on 10/24/2017 at 09:37:56 AM by trev

  • Blocking 5883 added
  • Cc greiner wspee nicole added

comment:2 Changed on 06/01/2018 at 04:55:44 PM by greiner

  • Cc agiammarchi added
  • Description modified (diff)
  • Owner set to greinermmarchi
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed on 08/06/2018 at 06:17:35 PM by greiner

  • Owner changed from greinermmarchi to agiammarchi

comment:4 Changed on 08/06/2018 at 06:18:07 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from agiammarchi.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.