Opened on 10/24/2017 at 11:09:15 AM
Closed on 10/27/2017 at 09:55:39 AM
#5916 closed defect (fixed)
Locale strings are broken in adblockpluschrome when building from Windows
Reported by: | kzar | Assignee: | oleksandr |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Automation | Keywords: | |
Cc: | oleksandr, sebastian, tlucas, trev | Blocked By: | #5913, #5915 |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
Windows 10, with creators update.
ActivePython 2.7.13
Node.js 6.11.4
Git 2.14.3
How to reproduce
- Click Node.js command prompt from the start menu.
- Type these commands:
git clone https://github.com/adblockplus/adblockpluschrome.git cd adblockpluschrome python build.py -t edge devenv
Note: Until #5913 is fixed you'll have to manually call npm install from the adblockpluschrome/buildtools directory. Until #5915 is fixed you'll have to change some paths in webpack_runner.js to c:\\.
Observed behaviour
All translatable strings in the extension are broken. These messages are displayed in the command line (reduced for brevity):
C:\Users\kzar\adblockpluschrome\buildtools\packager.py:139: UserWarning: Duplicate name: 'Extension/_locales/ar/messages.json' zf.writestr(name, self[name]) C:\Users\kzar\adblockpluschrome\buildtools\packager.py:139: UserWarning: Duplicate name: 'Extension/_locales/bg/messages.json' zf.writestr(name, self[name]) ... C:\Users\kzar\adblockpluschrome\buildtools\packager.py:139: UserWarning: Duplicate name: 'Extension/_locales/zh_CN/messages.json' zf.writestr(name, self[name]) C:\Users\kzar\adblockpluschrome\buildtools\packager.py:139: UserWarning: Duplicate name: 'Extension/_locales/zh_TW/messages.json' zf.writestr(name, self[name])
Expected behaviour
Build is created successfully.
Attachments (0)
Change History (5)
comment:1 Changed on 10/24/2017 at 11:13:49 AM by kzar
- Blocked By 5913, 5915 added
comment:2 Changed on 10/26/2017 at 09:17:13 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 10/26/2017 at 09:58:52 AM by kzar
- Owner set to oleksandr
- Priority changed from Unknown to P3
- Ready set
comment:4 Changed on 10/27/2017 at 09:52:56 AM by abpbot
comment:5 Changed on 10/27/2017 at 09:55:39 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5916 - Locale strings are broken in adblockpluschrome when building from Windows