Opened on 10/24/2017 at 05:44:25 PM
Closed on 01/24/2018 at 04:27:18 PM
#5927 closed change (rejected)
is there ever a real need to block HTML or BODY element?
| Reported by: | kiboke | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Unknown | Keywords: | |
| Cc: | kzar, greiner, sebastian, sergz, arthur, Khrin, fanboy | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
I am the developer of "i don't care about cookies" filterlist. In my case, I wanted to avoid hiding of body and html so all of my generic filters have to look like .some_class:not(body):not(html). There really are examples where web developers add the class "cookie-warning-box" both to BODY and the DIV which needs to be hidden. Without my expanded filter, the whole page would appear blank.
What to change
My proposal is that ABP never hides those specific elements, at least when applied filter is generic.
Attachments (0)
Change History (6)
comment:1 Changed on 12/28/2017 at 01:33:55 PM by sergz
- Cc kzar greiner sebastian sergz added
comment:2 Changed on 12/28/2017 at 01:38:11 PM by sergz
- Cc arthur added
comment:3 Changed on 01/04/2018 at 11:13:54 AM by kzar
comment:4 Changed on 01/22/2018 at 03:16:11 PM by arthur
- Cc Khrin fanboy added
Replying to kzar:
What do you think Arthur, can you think of a valid reason to block the entire document?
No, I cannot think of one to be honest. Would be a good idea for global filters imo.
comment:5 Changed on 01/24/2018 at 03:52:37 PM by kzar
Looking at EasyList I see three examples of :not(body) and none of :not(head). While I see your logic that filter list authors would rarely (or perhaps never) want to block those elements, I'm not sure that automatically appending :not(body) to all selectors is worth it.
comment:6 Changed on 01/24/2018 at 04:27:18 PM by kzar
- Resolution set to rejected
- Status changed from new to closed
I'll reject this therefore sorry, it's a logical suggestion but not workable in practice.
This sounds sensible to me and in fact we make the same assumption that the user doesn't want to block the entire document / body in the "block element" tool code.
What do you think Arthur, can you think of a valid reason to block the entire document?