Opened on 10/26/2017 at 04:30:22 PM

Closed on 08/29/2019 at 05:43:18 PM

#5946 closed defect (rejected)

shouldWrapAPIs in polifills breaks ABP for Edge

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: mjethani, geo, sebastian Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29589646/

Description

Environment

ABP for Microsoft Edge

How to reproduce

  1. Build Edge extension from 66d7de4087e5.

...

Observed behaviour

When opening the options page there is an exception, which breaks the page.

Error: Invocation of form storage.local.get(array) doesn't match definition storage.local.get(optional string or array or object keys, function callback).

Expected behaviour

Options page should work.

Add a required callback parameter to storage.local.get call.

Attachments (0)

Change History (3)

comment:1 Changed on 10/26/2017 at 04:30:59 PM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/05/2018 at 11:25:40 PM by sebastian

  • Cc geo sebastian added

Is this issue still relevant? Can anyone confirm that this error no longer occurs?

comment:3 Changed on 08/29/2019 at 05:43:18 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from reviewing to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.