Opened on 10/27/2017 at 11:20:45 AM

Closed on 11/02/2017 at 06:48:30 PM

#5952 closed defect (fixed)

Clicking Cancel in the issue reporter doesn't close the tab

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: mapx Blocked By:
Blocking: #5883 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29595588/

Description

Environment

Firefox 56, Adblock Plus 2.99.0.1898beta

How to reproduce

  1. Click ABP icon on any website
  2. Choose "Report issue on this page"
  3. Click Cancel or press Escape within the issue reporter page.

Observed behaviour

The page doesn't close. The console shows a warning:

Scripts may not close windows that were not opened by script.

Expected behaviour

The page should close, like it does in Chrome

Attachments (0)

Change History (7)

comment:1 Changed on 10/27/2017 at 12:54:42 PM by mapx

same here ("block element" empty window)
https://issues.adblockplus.org/ticket/5817#comment:6

comment:2 Changed on 10/27/2017 at 12:55:01 PM by mapx

  • Cc mapx added

comment:3 Changed on 11/02/2017 at 11:38:52 AM by trev

  • Owner set to trev
  • Summary changed from Clicking Cancel in the issue reporter doesn't close the tag to Clicking Cancel in the issue reporter doesn't close the tab

comment:4 Changed on 11/02/2017 at 11:40:31 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/02/2017 at 05:21:12 PM by greiner

  • Priority changed from Unknown to P2
  • Ready set

comment:6 Changed on 11/02/2017 at 06:47:26 PM by abpbot

comment:7 Changed on 11/02/2017 at 06:48:30 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.