Opened on 10/27/2017 at 02:17:52 PM
Closed on 10/27/2017 at 03:33:48 PM
Last modified on 10/30/2017 at 05:31:40 PM
#5955 closed defect (fixed)
DNT message in Firefox targets Chrome
| Reported by: | arthur | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | saroyanm, wspee, trev, kzar, Shikitita | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by saroyanm)
Environment
Firefox Nightly 58.0a1 20171026221945
ABP 2.99.0.1900beta
How to reproduce
- Open ABP options
- Tick "Only allow Acceptable Ads that are privacy-friendly"
Observed behaviour
The following text appears: Note:
You have Do Not Track (DNT) disabled in your Chrome settings. For this feature to work properly, please enable DNT in your browser preferences. Find out how to enable DNT.
Expected behaviour
It shouldn't be targeted to the chrome browser, see -> https://bitbucket.org/adblockplus/spec/issues/98/dnt-message-targets-chrome
Attachments (0)
Change History (8)
comment:1 Changed on 10/27/2017 at 02:22:44 PM by saroyanm
- Cc trev kzar Shikitita added
- Description modified (diff)
- Priority changed from Unknown to P1
- Ready set
comment:2 Changed on 10/27/2017 at 02:33:36 PM by saroyanm
- Owner set to saroyanm
This is only yet translated to Spanish, Catalan and Russian, I'll update Russian translation accordingly and Tamara will take care of the Spanish and Catalan.
comment:3 Changed on 10/27/2017 at 02:43:02 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 10/27/2017 at 03:32:59 PM by abpbot
A commit referencing this issue has landed:
Issue 5955 - Target browsers in general rather than chrome with the DNT message
comment:5 Changed on 10/27/2017 at 03:33:48 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 10/27/2017 at 04:23:55 PM by saroyanm
I wonder if it would be possible to push this translation to the crowdin though.
@kzar, @trev ?
comment:7 follow-up: ↓ 8 Changed on 10/30/2017 at 09:46:46 AM by kzar
To be honest I'm not sure why you're asking me for permission to push this string to the adblockplusui Crowdin project, that's not really my call.
FWIW we're supposed to be in a string freeze already (and a feature freeze) for the Firefox release next week. But I think we're probably going to need to update the adblockplusui dependency once more before then anyway.
comment:8 in reply to: ↑ 7 Changed on 10/30/2017 at 05:31:40 PM by saroyanm
Replying to kzar:
Thanks for reply.
To be honest I'm not sure why you're asking me for permission to push this string to the adblockplusui Crowdin project, that's not really my call.
Wasn't sure whom to ask while Sebastian was Out Of Office and didn't want to run it myself, as I haven't done it before and would probably need to have a permission to do that before running the script.
FWIW we're supposed to be in a string freeze already (and a feature freeze) for the Firefox release next week. But I think we're probably going to need to update the adblockplusui dependency once more before then anyway.
Yes I know, but I think this string change is important to fix before launch.
If it will not be possible to upload the string to crowdin meanwhilem I think it's better to have this in English only.
Thanks Arthur for finding this.