Opened on 10/30/2017 at 10:20:47 AM
Closed on 10/30/2017 at 10:31:29 PM
#5957 closed defect (fixed)
adblockpluschrome unit tests are broken
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, mjethani, trev | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Adblock plus for Chrome devenv built from f7eff6fa3af2.
How to reproduce
- Open the options page.
- In the developer console type location.href = "qunit/index.html";
Observed behaviour
A bunch of the tests fail with Uncaught ReferenceError: browser is not defined exceptions.
Expected behaviour
The tests pass.
Notes
- This is a regression from f9dfddb26058.
- Further regressions with the unit tests came from a5c2164d73ca and bef992c4eea1.
Hints for testers
This doesn't need testing since it won't have any effect on the build.
Attachments (0)
Change History (5)
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5957 - Get the unit tests passing again