Opened on 10/30/2017 at 04:45:02 PM
Closed on 09/07/2018 at 12:59:38 PM
Last modified on 06/05/2019 at 01:18:06 PM
#5960 closed change (fixed)
Fix incorrect source strings in "mobile options" project
| Reported by: | lisabielik | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | goodfirstbug |
| Cc: | wspee, saroyanm, greiner, Shikitita | Blocked By: | |
| Blocking: | #6936 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/106 |
||
Description
Background
There are two incorrect source strings in the mobile options project that need to be fixed.
What to change
Please enter a URL link to Please enter a URL
and
Allow some non-intrusive advertising to Allow some nonintrusive advertising
Attachments (0)
Change History (14)
comment:1 Changed on 10/30/2017 at 04:45:31 PM by lisabielik
- Cc Shikitita added
comment:2 Changed on 11/30/2017 at 10:50:20 AM by trev
- Cc greiner trev added; sebastian removed
- Component changed from Unknown to User-Interface
comment:3 Changed on 12/21/2017 at 11:26:28 AM by fhd
- Cc trev removed
comment:4 Changed on 01/15/2018 at 05:52:56 PM by greiner
- Keywords goodfirstbug added
- Priority changed from Unknown to P3
- Ready set
comment:5 Changed on 01/16/2018 at 02:37:10 PM by lisabielik
Any reason why this still hasn't been fixed? It's been 3 months.
comment:6 Changed on 01/16/2018 at 02:53:11 PM by greiner
It probably wasn't on anyone's radar and we may also have been a bit distracted by the web extension release. I went through all UI-related issues to make sure that they can be tackled so we should be back on track now.
comment:7 Changed on 09/06/2018 at 05:46:41 PM by greiner
- Owner set to greiner
The first string has already been fixed as part of #6659 and I've created [ui#] for the second string change.
Sorry that this has been taking so long.
comment:8 Changed on 09/06/2018 at 05:55:27 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 09/07/2018 at 12:59:38 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 09/07/2018 at 02:32:52 PM by greiner
- Blocking 6936 added
comment:11 Changed on 05/20/2019 at 10:58:29 AM by abpbot
A commit referencing this issue has landed:
Issue 5960 - Fixed: Corrected Acceptable Ads label in mobile options page
comment:12 Changed on 05/21/2019 at 10:26:03 AM by kzar
- Blocking 6936 removed
comment:13 Changed on 05/21/2019 at 11:18:21 AM by kzar
- Blocking 6936 added
comment:14 Changed on 06/05/2019 at 01:18:06 PM by ukacar
- Verified working set
I just filed a spec issue for the former (https://bitbucket.org/adblockplus/spec/issues/110/dont-use-the-bogus-term-url-link). The latter is already correct in the spec, merely not in the build. I consider the inconsistency to the desktop options page problematic however, filed https://bitbucket.org/adblockplus/spec/issues/111/inconsistent-terminology-between-desktop on it.