Opened on 11/01/2017 at 07:52:44 AM

Closed on 11/10/2017 at 12:04:15 PM

#5963 closed defect (fixed)

Fix alignment of product icon next to article title on help.eyeo.com

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: jeen, wspee, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29601607

Description (last modified by ire)

How to reproduce

  1. Clone help.eyeo.com repository
  2. Go to an article page with a long title, e.g. ​http://localhost:5000/en/adblockplus/is-adblock-plus-the-same-thing-as-adblock
  3. Resize browser to mobile size

...

Observed behaviour

See that the icon is aligned to the left and pushes the whole title. (see attachment)

Expected behaviour

Remove the icon on mobile only

Attachments (1)

localhost_5000_en_adblockplus_is-adblock-plus-the-same-thing-as-adblock(iPhone 6).png​ (110.6 KB) - added by ire on 11/01/2017 at 07:53:19 AM.
Example

Download all attachments as: .zip

Change History (10)

Changed on 11/01/2017 at 07:53:19 AM by ire

Example

comment:1 Changed on 11/01/2017 at 07:54:03 AM by ire

  • Description modified (diff)

comment:2 Changed on 11/01/2017 at 07:56:01 AM by ire

My suggestions:

  1. We move the icon to above the title
  2. We remove the icon altogether (on mobile only)

@jeen What do you think?

comment:3 Changed on 11/01/2017 at 08:07:10 AM by ire

  • Description modified (diff)

comment:4 Changed on 11/01/2017 at 08:08:49 AM by ire

  • Type changed from change to defect

comment:5 follow-up: Changed on 11/08/2017 at 09:46:07 AM by jeen

I say we remove the icon altogether for mobile - since the icon already appears in the breadcrumb anyway

comment:6 in reply to: ↑ 5 Changed on 11/08/2017 at 03:17:14 PM by ire

  • Description modified (diff)
  • Owner set to ire
  • Ready set

Replying to jeen:

I say we remove the icon altogether for mobile - since the icon already appears in the breadcrumb anyway

Alright. Thanks!

comment:7 Changed on 11/08/2017 at 03:37:42 PM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed on 11/10/2017 at 12:03:53 PM by abpbot

A commit referencing this issue has landed:
​Issue 5963 - Fix alignment of product icon next to article title on help.eyeo.com

comment:9 Changed on 11/10/2017 at 12:04:15 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.