Opened on 11/02/2017 at 01:07:06 PM
Closed on 11/03/2017 at 08:11:59 PM
Last modified on 11/06/2017 at 02:03:03 PM
#5973 closed defect (fixed)
[webextension] New options page icons display as blue squares in Firefox 50-52
| Reported by: | Ross | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | trev, sebastian, greiner, saroyanm | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
ABP 2.99.0.1903beta
Firefox 50-52 / Windows 10
Works in Firefox 53+.
How to reproduce
- Select [ABP Icon] > [Options].
- Select [Advanced].
Observed behaviour
The help/? icons in the general tab and the trash icons near the filter lists display as blue squares.
Expected behaviour
Icons to display correctly.
Attachments (1)
Change History (10)
Changed on 11/02/2017 at 01:09:08 PM by Ross
comment:1 Changed on 11/02/2017 at 08:57:53 PM by trev
- Cc greiner saroyanm added
comment:2 Changed on 11/03/2017 at 01:34:32 PM by saroyanm
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 11/03/2017 at 03:46:30 PM by saroyanm
- Owner set to saroyanm
comment:4 Changed on 11/03/2017 at 03:58:12 PM by saroyanm
I'm preparing patch for this one, Wladimir will you have time to review the patch ? (What is your availability?)
@Ross, what is your availability of doing tests ?
(I'll do tests before, during, after review, but will feel much more comfortable if you will be able to confirm in the end that changes works for you)
Patch should be ready around in 1 hour if I'll not notice any regression.
comment:5 Changed on 11/03/2017 at 05:48:25 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 11/03/2017 at 08:05:38 PM by abpbot
A commit referencing this issue has landed:
Issue 5973 - fixed broken icons on Firefox v50-53
comment:8 Changed on 11/03/2017 at 08:11:59 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 11/06/2017 at 02:03:03 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Icons display correctly.
ABP 3.0.0.1911beta
Firefox 50 / 53 / Windows 10
The icons currently use mask CSS property which is only supported starting with Firefox 53. Unfortunately, I don't see any easy way to fix this.