Opened on 11/03/2017 at 09:02:06 AM

Closed on 11/07/2017 at 07:26:05 AM

#5980 closed change (fixed)

Use correct browser logos for browser select on help.eyeo.com

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: jeen, juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29598558/

Description

Background

In #5692 we created a browser select dropdown that allows users to select their current browser. Since we didn't have the browser logos yet, we used the ABP logo as a placeholder.

What to change

Replace placeholder logo with correct logos for each of the browsers we support:

  • chrome
  • opera
  • samsungBrowser
  • yandexbrowser
  • maxthon
  • msie
  • msedge
  • firefox
  • ios
  • safari

Attachments (1)

help-center-browser-icons.zip (385.6 KB) - added by ire on 11/03/2017 at 10:28:46 AM.

Download all attachments as: .zip

Change History (6)

Changed on 11/03/2017 at 10:28:46 AM by ire

comment:1 Changed on 11/03/2017 at 10:29:04 AM by ire

  • Ready set

comment:2 Changed on 11/05/2017 at 06:18:40 PM by ire

  • Owner set to ire

comment:3 Changed on 11/05/2017 at 06:27:31 PM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 11/07/2017 at 07:25:47 AM by abpbot

comment:5 Changed on 11/07/2017 at 07:26:05 AM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.