Opened on 11/03/2017 at 01:55:57 PM
Closed on 05/24/2018 at 02:11:18 AM
Last modified on 10/30/2018 at 02:16:53 PM
#5987 closed change (fixed)
Remove ext.windows from adblockpluschrome
| Reported by: | kzar | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-3.2-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | goodfirstbug |
| Cc: | sebastian, Yael | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29787568/ |
||
Description
Background
With the changes for #5985 we removed the last use of ext.windows.create. We can now remove ext.windows from adblockpluschrome/ext/background.js.
What to change
- Remove ext.windows from adblockpluschrome/ext/background.js
Attachments (0)
Change History (11)
comment:1 Changed on 12/21/2017 at 11:29:03 AM by fhd
- Cc trev removed
comment:2 Changed on 05/15/2018 at 02:58:55 PM by kzar
- Ready set
comment:3 Changed on 05/23/2018 at 12:59:02 AM by jsonesen
- Owner set to jsonesen
comment:4 Changed on 05/23/2018 at 11:06:15 PM by jsonesen
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 05/23/2018 at 11:08:23 PM by abpbot
comment:6 Changed on 05/24/2018 at 02:11:18 AM by jsonesen
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 follow-up: ↓ 9 Changed on 05/24/2018 at 11:26:26 AM by kzar
Please can you add the Adblock-Plus-for-Chrome-Opera-Firefox-next milestone to this issue Jon?
comment:8 Changed on 05/24/2018 at 02:09:54 PM by jsonesen
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:9 in reply to: ↑ 7 Changed on 05/24/2018 at 02:10:19 PM by jsonesen
Replying to kzar:
Please can you add the Adblock-Plus-for-Chrome-Opera-Firefox-next milestone to this issue Jon?
Thanks for the reminder
comment:10 Changed on 06/21/2018 at 12:41:33 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Functionality such as Block element still works as expected.
ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7
comment:11 Changed on 10/30/2018 at 02:16:53 PM by kzar
- Cc Yael added
- Review URL(s) modified (diff)
Sorry I missed your merge request Yael, but I've CC'd you and linked to it at least.
A commit referencing this issue has landed:
Issue 5987 - Removes ext.windows