Opened on 11/17/2017 at 11:43:30 AM
Closed on 08/29/2019 at 05:43:18 PM
#6051 closed defect (rejected)
[webextension] Blocked iframes are not collapsed (hidden)
| Reported by: | gymka | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | externaldependencies, closed-in-favor-of-gitlab |
| Cc: | kzar, sebastian, mapx, Lain_13, dimisa, arthur | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Firefox 57
Adblock Plus 3.0.1
Windows 10 OR Linux (Debian Buster)
How to reproduce
- Add the filter ||alio.lt/infoNewAuto1200.html.
- Browse to http://margevicius.lt/adas.html
Observed behaviour
While the iframe is blocked from loading, the element itself is not collapsed (hidden). So it remains on the page, but empty.
Expected behaviour
The iframe element should be hidden as well as its src request blocked.
Notes
- This works as expected on Chrome.
- On both platforms a SUBDOCUMENT request to https://www.alio.lt/infoNewAuto1200.html is reported as being blocked.
- The problem seems to be caused by the fact that Firefox doesn't fire a load event for the blocked iframe where as Chrome does. On Chrome the frame is replaced and ends up with the location chrome-error://chromewebdata/ for which the load event is fired. On Firefox the frame isn't being replaced, the location is considered about:blank and therefore the load event is never fired.
Attachments (0)
Change History (20)
comment:1 Changed on 11/17/2017 at 11:55:27 AM by gymka
comment:2 Changed on 11/17/2017 at 01:39:57 PM by mapx
- Cc trev kzar sebastian mapx added
comment:3 follow-up: ↓ 4 Changed on 11/17/2017 at 01:42:35 PM by kzar
- Component changed from Unknown to Platform
- Description modified (diff)
- Summary changed from adb not see iframe with https:// or // url to [webextensions] Adblock Plus doesn't block iframe with https:// or // url
Which operating system are you using?
comment:5 Changed on 11/17/2017 at 02:06:01 PM by gymka
change line ||alio.lt/infoNewNT1200.html. to ||alio.lt/infoNewNTFooter1200.html. it's my error, but i can't modify original post
in original page there is both iframes, in my test page only 1
comment:6 Changed on 11/17/2017 at 02:08:03 PM by kzar
- Description modified (diff)
Done. (I think it was my error, I adjusted the filters when I edited the description earlier!)
comment:7 Changed on 11/18/2017 at 06:00:51 PM by kzar
- Summary changed from [webextensions] Adblock Plus doesn't block iframe with https:// or // url to [webextension] Adblock Plus doesn't block iframe with https:// or // url
comment:8 Changed on 11/18/2017 at 06:16:48 PM by kzar
- Owner set to kzar
- Priority changed from Unknown to P2
- Ready set
Please could you modify your test page so that it has two iframes, one using the // prefix and the other using the https:// prefix? That would make it easier for people to see the problem.
I can reproduce this, according to our devtools pane Adblock Plus blocks the SUBDOCUMENT request of http://www.alio.lt/infoNewNTFooter1200.html (note the http prefix despite the page using https), the iframe element is left empty on the page but not collapsed.
I'll investigate further next week.
comment:9 Changed on 11/19/2017 at 09:37:10 AM by gymka
when i'm testing in test page looks like problem is not about "" or "https" but with all url's, simply adblock plus 3.0.1 rules works differently then old version. old version blocked iframe and removed whitespace, 3.0.1 version only blocks iframe, but leaves whitespace.
issue is not with "src" protocol. then i tested in real life there was a lot of ads, so i assumed it's protocol fault.
comment:10 Changed on 11/20/2017 at 09:15:32 AM by kzar
- Description modified (diff)
- Summary changed from [webextension] Adblock Plus doesn't block iframe with https:// or // url to [webextension] Blocked iframes are not collapsed (hidden)
when i'm testing in test page looks like problem is not about "" or "https" but with all url's, simply adblock plus 3.0.1 rules works differently then old version. old version blocked iframe and removed whitespace, 3.0.1 version only blocks iframe, but leaves whitespace.
issue is not with "src" protocol. then i tested in real life there was a lot of ads, so i assumed it's protocol fault.
Aha, we're getting somewhere now, I've updated the issue again. Please could you update the test page so that there's only one iframe with the src of https://www.alio.lt/infoNewAuto1200.html ?
I'm going to start investigating what's going on today.
comment:11 Changed on 11/20/2017 at 09:16:28 AM by kzar
- Description modified (diff)
comment:12 Changed on 11/20/2017 at 10:35:02 AM by kzar
- Description modified (diff)
comment:13 Changed on 11/20/2017 at 11:18:55 AM by kzar
- Description modified (diff)
comment:14 Changed on 11/20/2017 at 12:53:37 PM by kzar
- Keywords externaldependencies added
I've filed a bug report with Mozilla about this: https://bugzilla.mozilla.org/show_bug.cgi?id=1418975
comment:15 Changed on 11/20/2017 at 02:14:40 PM by kzar
- Owner kzar deleted
comment:16 Changed on 11/21/2017 at 01:58:19 PM by Lain_13
Add me and dimisa into CC here please. Actually, is there a way to add myself into CC on issues without a request?
comment:17 Changed on 11/21/2017 at 01:59:31 PM by mapx
- Cc Lain_13 dimisa added
comment:18 Changed on 12/21/2017 at 11:30:13 AM by fhd
- Cc trev removed
comment:19 Changed on 01/23/2018 at 03:53:13 PM by arthur
- Cc arthur added
comment:20 Changed on 08/29/2019 at 05:43:18 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
for easier testing, my test page http://margevicius.lt/adas.html