Opened on 11/21/2017 at 04:09:54 PM
Closed on 01/24/2018 at 09:45:08 AM
Last modified on 02/16/2018 at 09:02:52 PM
#6066 closed change (fixed)
Implement 'force update' functionality for subscriptions
| Reported by: | jwangenheim | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.3 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | mario, tpregueiro, diegocarloslima, vickyyu | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by jwangenheim)
Background
Users should be able to force update all selected lists in a easy way. Currently users need to wait for the regular update or uncheck and check a subscription in order to update it.
What to change
Implement a functionality that enables the user to update all selected subscriptions.
Attachments (0)
Change History (12)
comment:1 Changed on 11/21/2017 at 04:11:04 PM by jwangenheim
- Cc mario tpregueiro diegocarloslima added
comment:3 Changed on 11/21/2017 at 04:12:02 PM by vickyyu
- Cc vickyyu added
comment:4 Changed on 12/13/2017 at 09:13:25 AM by jwangenheim
- Owner set to jwangenheim
comment:5 Changed on 01/15/2018 at 04:39:36 PM by vickyyu
comment:6 Changed on 01/16/2018 at 08:03:18 AM by jwangenheim
Hey vicky,
no progress so far, I just started looking into it before christmas.
I think we should prioritize the open tasks soon with mario.
comment:7 Changed on 01/17/2018 at 02:08:19 PM by jwangenheim
Do we even want to update the subscriptions if the user is on a metered connection? Should we use the existing setting from "Configure automatic updates" and rename it to "Configure updates"? Or should we show a dialog and ask/warn the user every time he wants to request an update? What should happen if the user clicks on "Update all subscriptions" but he is on a metered connection and only wants to update on a WIFI connection? We should probably show a Toast or something, right?
How should we go on, @vicky @mario?
comment:8 Changed on 01/18/2018 at 01:50:34 PM by jwangenheim
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 01/24/2018 at 09:44:41 AM by abpbot
A commit referencing this issue has landed:
Issue 6066 - Implement 'force update' functionality for subscriptions
comment:10 Changed on 01/24/2018 at 09:45:08 AM by jwangenheim
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 01/24/2018 at 09:49:10 AM by mario
- Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.3
comment:12 Changed on 02/16/2018 at 09:02:52 PM by rscott
- Verified working set
LGTM. Thank you so much for implementing this; in support especially, we'll appreciate it!
Hey Jens, what's the status here?
Some user insight: looks like some of them got issues due to filter lists not downloaded. However, it is hard for them to follow the steps to unclick and then reclick again of the filter list rather than one "force update" button.