Opened on 11/21/2017 at 09:46:35 PM
Closed on 11/28/2017 at 11:46:52 AM
Last modified on 12/07/2017 at 12:34:59 PM
#6070 closed defect (fixed)
Filter list not loaded after install without internet
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.3.3 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | mario, tpregueiro, jwangenheim | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Environment
One Plus 5
Android 7.1.1
Adblock Browser 1.3.2 (also happens on previous version 1.2.0)
How to reproduce
- Turn on airplane mode on the device
- Install ABB and open it
- After one minute, turn of airplane mode
- Navigate to a page where you should have ads blocked (or this ABP test page)
Observed behaviour
No ads are blocked (in case of the test page it shows EasyList is NOT installed/enabled) even though English/EasyList is enabled in Settings -> Ad blocking -> Languages. This is because the browser hasn't downloaded the filter list with the filter rules yet
Expected behaviour
After a short period of time, the browser should be able to block ads by downloading the filter lists ASAP. This happens because the ABP extension has a default retry time of 1 day when the filter fails to download, even if the filter was never downloaded before
Hint for testers
With this fix we've adjusted the time to check for and retry filter list downloads to every two minutes (starting 1 minute after the app loaded) instead of every 24 hours, as mobile connection can be flaky. In order to verify the fix, you'll need to wait a few minutes after re-enabling the internet connection before ad blocking works (instead of 24h).
Attachments (0)
Change History (9)
comment:2 Changed on 11/24/2017 at 11:20:10 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/28/2017 at 11:37:19 AM by abpbot
comment:4 Changed on 11/28/2017 at 11:46:52 AM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/01/2017 at 08:39:12 AM by mario
- Milestone set to Adblock-Browser-for-Android-1.3.3
comment:6 Changed on 12/01/2017 at 08:46:37 AM by mario
Assigned milestone prematurely for internal announcement purposes.
A commit referencing this issue has landed:
Issue 6070 - Filter list not loaded after install without internet