Opened on 12/01/2017 at 11:05:56 AM
Closed on 08/29/2019 at 05:43:18 PM
#6119 closed defect (rejected)
[webextension] Use frameAncestors for whitelisting
| Reported by: | tschuster | Assignee: | tschuster |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | kzar, sebastian, greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Legacy Adblock Plus for Firefox had this code https://hg.adblockplus.org/adblockplus/file/ee31d83e4fd7/lib/contentPolicy.js#l239 for whitelisting a request by looking at the whole parent chain of frames for that window. This is supported in Firefox 58 (currently beta) and up with the frameAncestors property. Implemented in huge parts by me in https://bugzilla.mozilla.org/show_bug.cgi?id=1305237. I am going to attach my patch for this very soon.
Attachments (0)
Change History (4)
comment:1 Changed on 12/11/2017 at 10:02:44 AM by kzar
- Cc kzar trev sebastian added
- Component changed from Unknown to Platform
- Milestone Adblock-Plus-3.0.2-for-Chrome-Opera-Firefox deleted
- Platform changed from Unknown / Cross platform to Firefox
- Summary changed from Use frameAncestors for whitelisting to [webextension] Use frameAncestors for whitelisting
comment:2 Changed on 12/21/2017 at 11:26:28 AM by fhd
- Cc trev removed
comment:3 Changed on 03/01/2019 at 04:31:18 PM by greiner
- Cc greiner added
comment:4 Changed on 08/29/2019 at 05:43:18 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Note: See
TracTickets for help on using
tickets.
Please could you update the issue description to add more context about this and what needs to be changed + tested and how?